search

khsing / laravel-world

provide countries, states, and cities relations and database.
MIT License
427 stars 89 forks source link

Publish Migrations #36

Open muarachmann opened 4 years ago

muarachmann commented 4 years ago

Hi first +1 to this package. However there is some need that the worlds... migration runs before the other migration tables. For example I have users table that has country_id, city_id references world_countries ... Can this be added to the vendor publish? so that we can modify the naming? as I see the publish command only seeds.

PS- I am running artisan migrate:fresh --seed or artisan db:migrate for the first time. Let me know if this is something you would like I can raise a PR

muarachmann commented 4 years ago

I see this was commented out here . I think a better way will be to rename the migrations to a date earlier than the default laravel users_table 2014_10_12_000000_create_users_table.php maybe to some older date 2013... what do you think @khsing ? https://github.com/khsing/laravel-world/blob/1de5a976a6e7069e9386dd97e2694c49454b1422/src/WorldServiceProvider.php#L42

khsing commented 3 years ago

@muarachmann I think it may not be a good way to do it. You can alter your users table after first initial.