search

khsing / laravel-world

provide countries, states, and cities relations and database.
MIT License
431 stars 90 forks source link

Incomplete Data of Countries/Divisions #49

Open afrasiyabhaider opened 3 years ago

afrasiyabhaider commented 3 years ago

I was using this package, But it doesn't have a complete record of all countries e.g Pakistan doesn't have any divisions Please complete the db if you need any assistance from me I'll be happy to assist you :)

@khsing

ilyaskazi commented 3 years ago

@afrasiyabhaider I stumble upon this package and installed. Same issue with db for country of India. No division found and incomplete list of cities.

@khsing This is a very good package but unfortunately having an incomplete db. Can you seed any good geo db which would be a good start for us when we install your package. This would motivate and keep going.

seche commented 3 years ago

I updated the seeds to have all countries, divisions and cities with 5000+ population in my pull request https://github.com/khsing/laravel-world/pull/51

Dach0 commented 2 years ago

I still cannot see some of the towns from GeoNames listed in cities5000.zip. (i.e. Split or (Šibenik)Sibenik from Coratia). And also, in WorldCitiesTableSeeder divisions are listed instead of cities for Croatia. I see some >5000 population cities are missing for countries like Serbia or Montenegro.

seche commented 2 years ago

I still cannot see some of the towns from GeoNames listed in cities5000.zip. (i.e. Split or (Šibenik)Sibenik from Coratia). And also, in WorldCitiesTableSeeder divisions are listed instead of cities for Croatia. I see some >5000 population cities are missing for countries like Serbia or Montenegro.

Good eye, I checked and it looks like divisions were added as cities for Croatia. I know I was having issues with cities because the tables are big. Let me see if I can re-run the cities portion. There should be 195 cities for Croatia as per my records. Will also check Serbia or Montenegro. Keep an eye on my next push ;)

Dach0 commented 2 years ago

OK, bear in mind that Serbia and Montenegro are separated countries from 2006 :) Maybe I could contribute to a package for Balkan countries if I catch some time in the near future. Anyway, I'll be watching this repo. Best regards.

seche commented 2 years ago

@Dach0 It took longer than expected and I probably spent way too much time on this but the data now includes all cities (200k~)

Its a lot of work migrating the data and would be easier to potentially convert the data model to match geonames but for now this should give us 99% there.

Dach0 commented 2 years ago

@Dach0 It took longer than expected and I probably spent way too much time on this but the data now includes all cities (200k~)

Its a lot of work migrating the data and would be easier to potentially convert the data model to match geonames but for now this should give us 99% there.

That's great news. I'll update the package and of course, recommend it to others :) Cheers, keep up the good work.