khu-khlug / sight-backend

쿠러그의 백엔드 어플리케이션 저장소
1 stars 0 forks source link

feat: 그룹 참여 구현 #58

Closed Coalery closed 2 weeks ago

Coalery commented 7 months ago

주요 변경 사항

그룹 참여 기능을 구현합니다.

변경 이유

기존 기능을 구현합니다.

github-actions[bot] commented 7 months ago

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/npx' failed with exit code 1
St.:grey_question:
Category Percentage Covered / Total
🟡 Statements
78.79% (+2.15% 🔼)
1077/1367
🔴 Branches
53.74% (+2.4% 🔼)
187/348
🔴 Functions
58.23% (+2.75% 🔼)
184/316
🟡 Lines
78.71% (+2.21% 🔼)
1009/1282
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------- | :--------- | :------- | :-------- | :---- | | 🟢 |
`...` / GroupAuthorizer.ts
| 100% | 87.5% | 100% | 100% | | 🟢 |
`...` / GroupMemberCreatedHandler.ts
| 100% | 61.11% | 100% | 100% | | 🟢 |
`...` / GroupMemberCreated.ts
| 100% | 100% | 100% | 100% | | 🟢 |
`...` / GroupDomainService.ts
| 100% | 70% | 100% | 100% | | 🟢 |
`...` / JoinGroupCommand.ts
| 100% | 100% | 100% | 100% | | 🟢 |
`...` / JoinGroupCommandHandler.ts
| 100% | 60% | 100% | 100% |

Test suite run failed

Failed tests: 1/178. Failed suites: 1/38.
``` ● GroupMemberCreatedHandler › handle › 운영진 공개 그룹이 아니라면 그룹장에게 메시지를 보내야 한다 expect(jest.fn()).toBeCalledWith(...expected) Expected: ObjectContaining {"targetUserId": "adminUserId"} Received: {"category": "GROUP_ACTIVITY_FOR_ME", "message": "message", "targetUserId": "userId"} Number of calls: 1 175 | await handler.handle(new GroupMemberCreated(groupId, userId)); 176 | > 177 | expect(slackSender.send).toBeCalledWith( | ^ 178 | expect.objectContaining({ targetUserId: group.adminUserId }), 179 | ); 180 | }); at Object.toBeCalledWith (app/application/group/eventHandler/GroupMemberCreatedHandler.spec.ts:177:32) ```

Report generated by 🧪jest coverage report action from dd061b12a83a271f8faee01487b5ea9878d5e596

Coalery commented 2 weeks ago

코드 변경이 상당히 많이 일어나 재구현하는 방향으로 잡고, 해당 PR은 닫습니다.