search

khuedoan / homelab

Fully automated homelab from empty disk to running services with a single command.
https://homelab.khuedoan.com
GNU General Public License v3.0
8.1k stars 742 forks source link

fix(argocd)!: use Server-Side Diff #149

Closed retX0 closed 6 months ago

retX0 commented 6 months ago

The issue has been close and fixed, see commit

khuedoan commented 6 months ago

Thank you, I just merged the ArgoCD upgrade to v6 so this is now available, I think it's better to enable it globally under bootstrap/argocd/values.yaml, since we'll need in in all Applications anyway:

argo-cd:
  configs:
    cm:
      # ...
    params:
      controller.diff.server.side: true

Ref: https://argo-cd.readthedocs.io/en/stable/user-guide/diff-strategies/#enabling-it

khuedoan commented 6 months ago

I also changed the title to indicate that this is a breaking change (switching from client side to server side may recreate some resources - at least in my setup)

retX0 commented 6 months ago

I pull my code and changed the code.