made QoL adjustments and file cleanup

[brimdor]

• replaced specific unique items with placeholders (ex. khuedoan.com is now )
• added a placeholder for control plane endpoint
• added reset script
• added cronjobs
• added nfs_utils
• adjusted the configure script to utilize placeholders
• added a branch option in case someone wants to use a different branch than master
• removed old configure and added new configure script

[khuedoan]

Hi, thank you for making a PR. However, it seems like this should be split into multiple PRs to make it more reviewable and reduce the blast radius.

Although these changes are unlikely to be merged for the following reasons:

• Placeholders: Using khuedoan.com is intentional. This project is meant to be applied directly in my homelab, with a script to make it more convenient to adapt to your homelab. It's not meant to be a template repo.
• Reset script: This is unnecessary since the nodes are designed to be cattle, not pets. To reset them, you can simply turn them off and run make to rebuild (same thing for the repo, you can nuke the entire repo and fork it again)
• Cronjobs: Shouldn't this already be covered by the automatic upgrade?
• nfs_utils: I'm assuming this is for RWX volumes, does the standard-rwx storage class suffice? (It was added as part of the Ceph migration)
• Branch option: I don't plan to change my default branch, and it will complicate the installation instructions (e.g., "if you want to change the branch, you have to fork, checkout a new branch, change the default branch in GitHub, change this and this, etc."). It unnecessarily increases friction without any benefit.

[brimdor]

Thanks for the info. It sounds like I didn't understand the primary purpose and use case of your homelab. No problem.

On Mon, May 13, 2024, 05:31 Khue Doan @.***> wrote:

Hi, thank you for making a PR. However, it seems like this should be split into multiple PRs to make it more reviewable and reduce the blast radius.

Although these changes are unlikely to be merged for the following reasons:

• Placeholders: Using khuedoan.com is intentional. This project is meant to be applied directly in my homelab, with a script to make it more convenient to adapt to your homelab. It's not meant to be a template repo.
• Reset script: This is unnecessary since the nodes are designed to be cattle, not pets. To reset them, you can simply turn them off and run make to rebuild.
• Cronjobs: Shouldn't this already be covered by the automatic upgrade?
• nfs_utils: I'm assuming this is for RWX volumes, does the standard-rwx storage class suffice? (It was added as part of the Ceph migration)
• Branch option: I don't plan to change my default branch, and it will complicate the installation instructions (e.g., "if you want to change the branch, you have to fork, checkout a new branch, change the default branch in GitHub, change this and this, etc."). It unnecessarily increases friction without any benefit.

— Reply to this email directly, view it on GitHub https://github.com/khuedoan/homelab/pull/159#issuecomment-2107217437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFVDYE3JQUTVDHFH4LMW3ZCCI7RAVCNFSM6AAAAABHQULJEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGIYTONBTG4 . You are receiving this because you authored the thread.Message ID: @.***>