khughitt / EuPathDB

EuPathDB recipe for the Bioconductor AnnotationHub
2 stars 4 forks source link

r cmd check passes without shenanigans, vignettes rebuild, tests pass. #13

Closed abelew closed 5 years ago

abelew commented 5 years ago

The only annoyance that remains is the fact that the EuPathDB folks keep messing with the orthologs table(s).

khughitt commented 5 years ago

Nice work!! :+1: I'll try and look into Travis error later, but gonna merge this in for now. Thanks!

khughitt commented 5 years ago

Actually, do you want to update the README.md as well so that it reflects the multiple uses of the package? Currently still focussed on AH use...

abelew commented 5 years ago

I have a question about this: would it be worth while to remove the r blocks from the readme and instead have a pointer directly to the vignette(s)?

khughitt commented 5 years ago

Hmm. That is probably not a bad idea :+1:

khughitt commented 5 years ago

Feel free to take out my section when you update the README (it is already covered in the vignette in more detail..)