search

khui / copacrr

The code for COPACRR Neural IR model.
Apache License 2.0
38 stars 11 forks source link

Redundant loop #3

Closed JoaoLages closed 6 years ago

JoaoLages commented 6 years ago

https://github.com/khui/repacrr/blob/aa5251280455a06314fe6064393649dff60bd496/pred_per_epoch.py#L57

On line 57 you have for qid in qid_cwid_pred: this is a redundant loop as you'll do another loop like this in line 61. Minor bug, but wanted to report it anyway.

khui commented 6 years ago

Hi Joao,

Thanks for the report. I will take care of it.

Best, Kai