Submitting Rotten Tomatoes Homework Assignment

[khuong291]

Here is my completed homework assignment! Thank you /cc @coderschoolreview

[coderschoolreview]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

• Great clean code. Good job utilzing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide Please keep re-indent in Podfile also.
• You don't need to use bridging-header file to import AFNetworking. Just use pod. If this file is useless, remove it.
• Nice work implementing the Movie model. A tiny note: remove the constructor if it's empty.

init() {

    }

or you should create the constructor like this (make the parse func more clear)

init(data: NSDictionary) {
  // your code
}

• Both code blocks are similar. You can refactor them.

        // Movies
        let moviesVC = storyboard.instantiateViewControllerWithIdentifier("MediaList") as! MediaListViewController
        moviesVC.title = "Movies"
        moviesVC.tabBarItem.image = UIImage(named: "superman")?.imageWithRenderingMode(.AlwaysOriginal)
        moviesVC.mediaType = .Movie
        let moviesNC = UINavigationController(rootViewController: moviesVC)
        moviesNC.navigationBar.barTintColor = UIColor.blackColor().colorWithAlphaComponent(0.5)
        moviesNC.navigationBar.tintColor = UIColor.yellowColor()
        moviesNC.navigationBar.barStyle = UIBarStyle.Black
        moviesNC.navigationBar.titleTextAttributes = [NSForegroundColorAttributeName: UIColor.redColor()]

        //DVDs
        let dvdsVC = storyboard.instantiateViewControllerWithIdentifier("MediaList") as! MediaListViewController
        dvdsVC.title = "DVDs"
        dvdsVC.tabBarItem.image = UIImage(named: "hulk")?.imageWithRenderingMode(.AlwaysOriginal)
        dvdsVC.mediaType = .DVD
        let dvdsNC = UINavigationController(rootViewController: dvdsVC)
        dvdsNC.navigationBar.barTintColor = UIColor.blackColor().colorWithAlphaComponent(0.5)
        dvdsNC.navigationBar.tintColor = UIColor.yellowColor()
        dvdsNC.navigationBar.barStyle = UIBarStyle.Black
        dvdsNC.navigationBar.titleTextAttributes = [NSForegroundColorAttributeName: UIColor.redColor()]

• Why did you need to create both MediaListViewController and MediaSearchViewController? You can use only MediaListViewController and add UISearchBar, then implement UISearchBarDelegate in the view controller.
• Your custom Media cell should have a property called movie. In the custom setter of media, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Good job with Alamofire :+1: This helps you request API easier, right?
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure.
• Nice job implementing UITextView to show the synopsis. But you should disable editing of this text. For now, I can edit the synopsis and have no way to dismiss the keyboard.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• A small problem: this white gap appear when searching.
• In MediaCell.swift, if you don't implement anything in these functions, remove them.

override func awakeFromNib() {
        super.awakeFromNib()
        // Initialization code
    }

    override func setSelected(selected: Bool, animated: Bool) {
        super.setSelected(selected, animated: animated)

        // Configure the view for the selected state
    }

• Remember adding a blank line at the end of each file to prevent github's blame.
• Please use Assets.xcassets to manage your images.

Good submission overall :smile: Homework is the core part of this class. Through the homework assignments you'll create real apps that you should be proud to show anybody. The more time you spend, the better your portfolio will be and the more you will learn. Try to spend a little more time next week!