khushpanchal / Ketch

An Android File downloader library based on WorkManager with pause and resume support.
https://medium.com/@khush.panchal123/ketch-android-file-downloader-library-7369f7b93bd1
395 stars 26 forks source link

Refactor to represent download state using Flow #3

Closed PrimoDev23 closed 1 month ago

PrimoDev23 commented 3 months ago

Hey, I just decided to give this a try, so feel free to apply that PR to your library. This refactoring solves some issues like memory leaks that might occur when injecting an instance of Ketch. Also I removed the DownloadManager as a state holder, since the user of the library should better take care of state handling and freeing resources.

This way the library also follows a more reactive approach. Feel free to comment on it.

khushpanchal commented 3 months ago

Noted @PrimoDev23 thanks, I will check the PR and get back.

khushpanchal commented 1 month ago

@PrimoDev23 I have made the major update in Ketch with support of pause and resume functionality. In this version made the database as single source of truth and changed complete approach making it more reliable, please checkout Version 2.0.0 https://github.com/khushpanchal/Ketch

Please feel free to check out, this version makes library more flexible with less client interactions.