search

khwang0 / 2018F-COMP3111

19 stars 13 forks source link

[Testing Procedure] Lab Machine uses JDK 10 #101

Open Derppening opened 5 years ago

Derppening commented 5 years ago

In #93, you mentioned the testing procedure is using the following set of commands on lab machines:

git clone <your_URL>
.\gradlew build
.\gradlew test
.\gradlew jacocoTestReport
.\gradlew javadoc
.\gradlew run

However, I have come to realize that lab machines use JDK 10 by default, as seen by the following screenshot.

Screenshot

The JAVA_HOME environment variable points to C:\Program Files\Java\jdk, which is a shortcut to C:\Program Files\Java\jdk-10.0.1.

Screenshot

This has caused some behavioral changes in regards to Java API deprecations and JavaFX behavior.

Could you please clarify the testing procedure to include a command to set JAVA_HOME to the proper JDK 8 installation?

comp3111ta commented 5 years ago

If you need that, you can state it in your readme.md