search

khwang0 / 2018F-COMP3111

19 stars 13 forks source link

Url #32

Open JackShDr opened 6 years ago

JackShDr commented 6 years ago

The scraped datas' urls are in a wrong form such as https://newyork.craigslist.org/https://newyork.craigslist.org/brk/sys/d/15-inch-macbook-pro-512gb-hd/6732313538.html, because of this line of code in the WebScraper.java: "item.setUrl(DEFAULT_URL + itemAnchor.getHrefAttribute());". Is this designed to work like this or a bug?

comp3111ta commented 6 years ago

Probably not intentional. Not sure why but when I implemented that it worked .... Anyway. The base code would not be updated and you need to finish it. Sorry about that.

ghost commented 6 years ago

@t3i3n1 @tsngaa We might need to pay attention to this... Fix the URL on Console lab 😆

comp3111ta commented 5 years ago

You can modify anything you want.

On Sun, 11 Nov 2018 at 3:45 PM, wilsonyau1021 notifications@github.com wrote:

Probably not intentional. Not sure why but when I implemented that it worked .... Anyway. The base code would not be updated and you need to finish it. Sorry about that.

So should we modify it? @comp3111ta https://github.com/comp3111ta

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/khwang0/2018F-COMP3111/issues/32#issuecomment-437650244, or mute the thread https://github.com/notifications/unsubscribe-auth/AflWFaR2PmIx2s7dqHBpXF9TPe0JIlBQks5ut9W2gaJpZM4YDrA3 .