khyperia / weechat-discord

Unmaintained! And also apparently this is against their TOS so DON'T USE THIS -- Weechat plugin for Discord support - https://weechat.org/ https://discordapp.com/
MIT License
51 stars 24 forks source link

Discord API returns channels the user is not in. weechat-discord should filter these out. #27

Closed riconnon closed 7 years ago

riconnon commented 7 years ago

The discord API returns channels the user is not a member of when channels are listed. See following thread: https://www.reddit.com/r/discordapp/comments/5mm0qp/bug_windows_phone_discord_users_can_see_channels/

Seems like discord expect clients to implement this filtering.

khyperia commented 7 years ago

Should be relatively simple to implement alongside #16. I plan on fixing both issues soon, after the huge refactoring I did this weekend that made a lot of this code way easier to work with (and implement these types of features). Thanks for the report!

khyperia commented 7 years ago

Should have been closed by 1bb57f0d640431598da043edb8e89a1ff4f8036b, but I typo'd 21 instead off 27. My bad! This is implemented now :)

khyperia commented 7 years ago

Never mind. Apparently this broke stuff. https://github.com/khyperia/weechat-discord/issues/33 is now tracking this issue (I just ripped out the fix for this in https://github.com/khyperia/weechat-discord/commit/b073649ad8b3d723b94e84642d5a77c981a112ca )