search

kiall / android-tvheadend

Android + TV Headend + TV Input Framework
Apache License 2.0
191 stars 61 forks source link

Support EIA/CEA-708 Closed Captions #103

Open kiall opened 7 years ago

kiall commented 7 years ago

Block on ExoPlayer support:

https://github.com/google/ExoPlayer/issues/1807

kiall commented 7 years ago

Originally brought up on G+ https://plus.google.com/115557954602502982039/posts/TkZ4i7bWBRz by L.Tran

kiall commented 7 years ago

This should be fixed in builds which use ExoPlayer 2.2.0+ https://github.com/google/ExoPlayer/commit/18a24a1fde68753737030bac9c7d56e6e7c292e4

I don't have any content to test this with (that I know of!), and there are still some issues which have been found and fixed, but aren't in a ExoPlayer release yet: https://github.com/google/ExoPlayer/commit/537a3ab5be3fcf285b17505ac64c28b5f68c8fbb

I'm going to close this one out, please reopen anyone has content with EIA/CEA-708 captions and it's not working.

xaudiblex commented 7 years ago

I just gave the update a try & there are no options for captions. However, if I use Google's network tuner implementation, it shows CC as an option & captions properly work.

kiall commented 7 years ago

Thanks, will have to see if there's something else needed to make this work :(

kiall commented 7 years ago

By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump

xaudiblex commented 7 years ago

Yeah I will give it a shot sometime this weekend.

⁣Sent from BlueMail ​

On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes notifications@github.com wrote:

By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kiall/android-tvheadend/issues/103#issuecomment-282236601

xaudiblex commented 7 years ago

Would you happen to know how to do this in windows?

⁣Sent from BlueMail ​

On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes notifications@github.com wrote:

By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kiall/android-tvheadend/issues/103#issuecomment-282236601

xaudiblex commented 7 years ago

Nevermind.  I figured it out!

http://www.mediafire.com/file/dqbsvghamqtg143/ATSC_Sample.ts

⁣Sent from BlueMail ​

On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes notifications@github.com wrote:

By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kiall/android-tvheadend/issues/103#issuecomment-282236601

kiall commented 7 years ago

@xaudiblex are you sure that contains any subtitles? Neither VLC / ffmpeg show that clip as having any subtitles.. Also - it looks like the "profile=pass" piece of the URL was missed, the linked file is a Matroska / MKV file, which could be the reason the captions are missing.

Whatever URL you used, you'll need to add the profile piece to it so it gives the raw mpeg-TS data

kiall commented 7 years ago

Oh. The docs don't have the profile=pass piece in it, heh. let me update them.

kiall commented 7 years ago

Ah, Nevermind, it looks like you recorded from a channel, rather than from the service or mux.

Recording from a service/mux URL is always in MPEG-TS. I've updated Step 1 of the muxdump wiki to be more clear, could you have another look and try again? Thanks!

xaudiblex commented 7 years ago

Hopefully this is what we need.

http://www.mediafire.com/file/yhywli7c7zpc2so/ATSC_Sample_Service_Mux.ts

⁣Sent from BlueMail ​

On Mar 18, 2017, 4:57 PM, at 4:57 PM, Kiall Mac Innes notifications@github.com wrote:

Ah, Nevermind, it looks like you recorded from a channel, rather than from the service or mux.

Recording from a service/mux URL is always in MPEG-TS. I've updated Step 1 of the muxdump wiki to be more clear, could you have another look and try again? Thanks!

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/kiall/android-tvheadend/issues/103#issuecomment-287577793

kiall commented 7 years ago

Sorry, been travelling so haven't been near the app for a few weeks!

As near as I can see, this file still doesn't contain a EIA/CEA caption stream? Also, it's still an MKV file. I'm not sure why you're getting MKV instead of a MPEG-TS stream.

Input #0, matroska,webm, from '/home/kiall/Downloads/ATSC Sample Service Mux.ts':
  Metadata:
    title           : ATSC-T Network/599.028MHz/KDFW DT
    encoder         : Tvheadend Matroska muxer
  Duration: N/A, start: 0.000000, bitrate: N/A
    Stream #0:0(eng): Video: mpeg2video, none(progressive), 1280x720, SAR 1:1 DAR 16:9, 59.96 fps, 59.96 tbr, 1k tbn, 119.88 tbc (default)
    Stream #0:1(eng): Audio: ac3, 48000 Hz, 5.1(side), 448 kb/s (default)
    Stream #0:2(spa): Audio: ac3, 48000 Hz, stereo, 192 kb/s (default)
kiall commented 7 years ago

Removing Upstream Limitation label, as ExoPlayer does seem to support this now.. I just need sample content to get it going!

kiall commented 6 years ago

See https://github.com/kiall/android-tvheadend/issues/203