An `int` divided by an `int` will always return an `int`, even when t…

kiall / android-tvheadend

Android + TV Headend + TV Input Framework

Apache License 2.0

191 stars 61 forks source link

An `int` divided by an `int` will always return an `int`, even when t… #187

Closed girlpunk closed 7 years ago

girlpunk commented 7 years ago

…he variable it is being stored to is a float. Explicitly casting one of the numbers to a float stops this.

kiall commented 7 years ago

I'm fine with this change - however, I happen to know the CI / build will barf on the backticks (or quotes) in the commit titles and break the changelog generation - I've been meaning to fix that ;)

In the meantime, could you amend the commit title?

git commit --amend -> change title to remove backticks and quotes
git push origin fix-float-error-pull --force

Thanks :)

kiall commented 7 years ago

Oh, looks like I already merged some with backticks. Oh well, merging ;)