search

kiall / android-tvheadend

Android + TV Headend + TV Input Framework
Apache License 2.0
191 stars 61 forks source link

Another place to use try-with-resources #195

Closed girlpunk closed 7 years ago

girlpunk commented 7 years ago

re-add try with resources for inputStream. As the comment says, don't try this with the ObjectInputStream object, it creates some very strange issues (constant buffering and graphical issues) that took me a while to track down.

kiall commented 7 years ago

Can we target these to the develop branch instead of master?

After some recent changes, master is intended to be stable, with only critical bugfixes landing there so I can release them easily... develop is where the next version is being worked on, once ready, it'll will be merged over to `master..

girlpunk commented 7 years ago

Changed to develop, but doesn't look like this will go through cleanly. I'll fix it as necessary and re-open it when everything is ready