search

kianzarrin / NodeController

10 stars 9 forks source link

Potential incompatibility with another mod #20

Closed sway2020 closed 4 years ago

sway2020 commented 4 years ago

I noticed that Node Controller and my mod(Gravitative Cable Car) patch the same method (Vehicle's RenderInstance). My mod is poorly written as it is more like a proof-of-concept and I didn't really know how to use transpiler. Will node controller ever modify the behavior of cable cars? If not, is it possible to add a simple vehicle type check in node controller's prefix patch to avoid incompatibility? Thanks.

https://github.com/sway2020/GravitativeCableCar/blob/b1203a7eadf24f53b779b6ad2aab228ef901b1bc/GravitativeCableCar.cs#L69

kianzarrin commented 4 years ago

I am not patching Vehicle's RenderInstance. you didn't see the commented out//[HarmonyPatch()] I should really remove that file. that file was just for experimenting. Even if I did BTW prefixes are not incompatible. you can use [HarmonyAfter/Before(ID)]

sway2020 commented 4 years ago

Sorry for bothering you. I still have a lot to learn....