search

kiber-pacan / item-placer-arch

0 stars 1 forks source link

Port to 1.19.2, minor additions/adaptions #3

Closed CCr4ft3r closed 2 months ago

CCr4ft3r commented 2 months ago

Hello there 👋

I've ported your great mod to 1.19.2. In additon to that I made some minor additions/adaptions:

Sorry for the new formatting of ItemPlacerCommon - it was changed automatically right after the checkout of the original branch (even if I added a further indent like in the original file, the lines were marked as changed).

CCr4ft3r commented 2 months ago

The reformatted lines dissappears when using the option "Hide whitespace".

kiber-pacan commented 2 months ago

watahel

kiber-pacan commented 2 months ago

busy, not now

kiber-pacan commented 2 months ago

should have used master branch :/

CCr4ft3r commented 2 months ago

Why's that?

kiber-pacan commented 2 months ago

bcs it is main dev branch

kiber-pacan commented 2 months ago

look at versions folder and build.sh script

CCr4ft3r commented 2 months ago

Oh my bad. Should I create a new 1.19.2 branch based on the master?

kiber-pacan commented 2 months ago

do whatever you want

CCr4ft3r commented 2 months ago

I saw that you are moving to a new repository. So my pull request will be obsolete. I will wait until it's finished and create a new request based on the branch in the new repository.

kiber-pacan commented 2 months ago

i probably just gonna implement myself all the stuff you listed in the first comment while rewriting mod

kiber-pacan commented 2 months ago

would be nice if you gave ideas for this mod or created pull request with them already implemented

CCr4ft3r commented 2 months ago

At the moment I don't have further ideas besides those included in this pull request.

Do you want to backport the new project to 1.19 2 by yourself? If not could you inform me when you are mostly finished?

Closing this for now. Thanks for your great work 👍

kiber-pacan commented 2 months ago

yeah im gonna port to 1.19 and also to 1.18 1.17 1.16