kibertoad / unzipomatic

Modern unzipping library for Node.js
MIT License
3 stars 0 forks source link

Slice and TS-ify yauzl code #10

Closed kibertoad closed 5 months ago

kibertoad commented 5 months ago

fixes #5

Changes

This is a first pass of integrating yauzl codebase. It's not going to compile or pass linting yet, but it should represent entire runtime codebase of yauzl, split into separate files and turned into mostly correct TypeScript. I would suggest merging it quickly after quick sanity check and iterating over it in subsequent PRs.

Checklist

kibertoad commented 5 months ago

@H4ad I used PascalCase for classes, and camelCase for the rest. I'm open to using kebab-case for non-classes if you prefer that.

I had two folders, yauzl and yauzl-ts when I started, and kept converting until only yauzl-ts was left. probably we can rename it to just yauzl and start extracting pieces that we are happy with outside of it.

will merge as-is to keep iterations fast, but let's improve on this in follow-ups

I won't have computer access today anymore, but can review something if you have capacity to work on something today