search

kibertoad / unzipomatic

Modern unzipping library for Node.js
MIT License
3 stars 0 forks source link

Port fd-slicer #13

Closed H4ad closed 7 months ago

H4ad commented 8 months ago

Because of https://github.com/andrewrk/node-fd-slicer/pull/5

kibertoad commented 8 months ago

@H4ad @metcoder95 Should we inline the library inside this repo, or publish @unzipomatic/fd-slicer?

H4ad commented 8 months ago

It's very downloaded too, so I think that worth to fork and publish a new version, also, I don't think we should put under organization and publish as a independent library

kibertoad commented 8 months ago

@H4ad How can we avoid name clash then, if there is no organizational prefix? Rename to something like fd-sliceomatic :D?

H4ad commented 8 months ago

Yes, or "better-fs-slicer", something like that.

metcoder95 commented 8 months ago

Are we planning to take portions of code from it, it do a direct port/rewrite?

kibertoad commented 8 months ago

I would start by forking it, and change what makes sense

H4ad commented 8 months ago

I started the porting, @kibertoad, once you have the repo, I can push the changes.

I already finished the rewriting of code, I just need to finish the tests.

kibertoad commented 8 months ago

@H4ad Done: https://github.com/kibertoad/better-fd-slicer