search

kibertoad / unzipomatic

Modern unzipping library for Node.js
MIT License
3 stars 0 forks source link

Inline buffer-crc32 to avoid deprecations #16

Closed kibertoad closed 8 months ago

kibertoad commented 8 months ago

https://github.com/brianloveswords/buffer-crc32/blob/master/index.js uses deprecated Buffer API. Inlining entire library (it is tiny) might be the easiest fix for it.

Let's see if author reacts to https://github.com/brianloveswords/buffer-crc32/issues/20, though

H4ad commented 8 months ago

Should we migrate to https://www.npmjs.com/package/@node-rs/crc32 or keep this one?

kibertoad commented 8 months ago

@H4ad I've created separate ticket for migration, but it is not critical for the first release. buffer-crc32 author merged all of my PRs, so short-term we are good.