kibertoad / unzipomatic

Modern unzipping library for Node.js
MIT License
3 stars 0 forks source link

Migrate tests to vitest #6

Closed H4ad closed 1 month ago

H4ad commented 5 months ago

This is something we can do in parallel to #5, we can modernize the tests and use vitest to be easier to work on and add more tests.

kibertoad commented 5 months ago

This is probably currently blocked by https://github.com/kibertoad/unzipomatic/issues/4

H4ad commented 5 months ago

Not exactly, it we do in the following order:

Then we will be able to do it in parallel.

I suggested this way instead of starting the rewriting using the new design because none of us are familiar with the code of that library and the easiest way to understand is just to transpile to typescript while maintaining the same functionality/design.

But I'm not against starting the lib already in the new design.

kibertoad commented 5 months ago

@H4ad Fair point. Can you pick this one up after we merge https://github.com/kibertoad/unzipomatic/pull/10 ? converting just few tests to ensure our code still runs correctly would be very valuable

H4ad commented 5 months ago

Sure!

H4ad commented 1 month ago

This is basically solved now.