search

kibicat / mastodon

A Mastodon‐compatible fediverse instance (the one used by https://glitch.cat.family).
GNU Affero General Public License v3.0
3 stars 0 forks source link

`from`: search prefix 500s when the supplied account cannot be found #36

Closed single-right-quote closed 2 years ago

single-right-quote commented 2 years ago

see mastodon/mastodon#17941

importing here as my WIP commits keep spamming the issue upstream

single-right-quote commented 2 years ago

https://github.com/kibicat/mastodon/commit/945c9b1342b7a000da05074e4572abe6ce7feb9c strictly solves the issue and also changes behavior in ways i personally find preferable. it litters changes across the codebase and i don’t know if i like that

i think the way i raise errors to handle the problem is very sketch; i would like to better understand the control flow for text search so i can handle things in a more idiomatic- and cleaner-feeling way

i would like to see the search API capable of sending error responses; and i would like to see the front end not just throw them at the toast, probably displaying such errors in the search results column

single-right-quote commented 2 years ago

https://github.com/mastodon/mastodon/pull/17963