search

kibicat / mastodon

A Mastodon‐compatible fediverse instance (the one used by https://glitch.cat.family).
GNU Affero General Public License v3.0
3 stars 0 forks source link

[REGRESSION] Unbreak yarn builds when migrating to yarn stable by regressing to non-lazy emoji-mart #38

Closed single-right-quote closed 2 years ago

single-right-quote commented 2 years ago

Upstream mastodon has been using a fork of emoji-mart that supports lazy-loading emoji{s,m}. Unfortunately, it is presently breaking builds when using yarn>=2, which is required by the asset precompilation script as of Mastodon 3.5.0. Using upstream emoji-mart unbreaks the build, so I suppose we must deal with the performance loss.

The emoji-mart fork’s issue appears to simply be its version number (!?), so we could try hosting a fork and changing the version number to something yarn (or is it npm?) will accept, and using a git link in the package.json.

marrus-sh commented 2 years ago

or use a git link to a commit hash with no version number

when i actually get a running mastodon on my computer again i’ll try to look into this

single-right-quote commented 2 years ago

~or use a git link to a commit hash with no version number~

i tried that and yard complained about the version number anyway

single-right-quote commented 2 years ago

this PR merge conflicts with glitch-soc 3.5.1’s yarn.lock

single-right-quote commented 2 years ago

this PR merge conflicts with glitch-soc 3.5.1’s yarn.lock

this PR is now using upstream's yarn.lock

single-right-quote commented 2 years ago

yarn set version latest gets around this problem

this directly contradicts upstream’s instructions to use stable (a change made basically at the time of 3.5.0’s release), but works. we should raise an issue about this.