search

kiboko-labs / akeneo-connector-base

Tools for Akeneo connector developers
4 stars 2 forks source link

One does not simply alter something in the vendors folder #3

Closed mathewrapid closed 8 years ago

mathewrapid commented 8 years ago

Note: This will need a small patch in method Pim\Bundle\ImportExportBundle\Twig\NormalizeConfigurationExtension::normalizeValueFilter()

In many cases (or almost always) the deployment processes do not use the developers local vendors content and/or use the composer.lock file to install the correct dependencies. This results into that any changes made in the vendors folder will get overwritten by composer.

I'd recommend to add your own NormalizeConfigurationExtension class and just to override the services class parameter pim_import_export.twig.normalize_configuration_extension.class to point to it. This way the changes won't get lost.

gplanchat commented 8 years ago

Yes. You have a good point.

Better than this, I just made a PR to Akeneo itself akeneo/pim-community-dev/pull/4529

gplanchat commented 8 years ago

The fix was merged on https://github.com/akeneo/pim-community-dev/commit/650b05ce2a7d0d57db38be728b29fc6fed726824