kibook / pmms

Synchronized media player for FiveM and RedM
136 stars 57 forks source link

YouTube ads read in PMMS #98

Open Thnight86041 opened 1 month ago

Thnight86041 commented 1 month ago

Currently on the latest version of pmms I have all the ads for each video taken from youtube. Is there a way to patch ?

Edmondio commented 1 month ago

same for me ..

dahtslash commented 1 month ago

Same... if I find a workaround Ill pull. Damn yt.

JordanZABOT commented 1 month ago

The workaround I was trying to do involved auto-clicking the skip ads button but I kept running into issues. I just didn't have time to continue working on it. Maybe I will find some motivation to work on it this weekend

JordanZABOT commented 1 month ago

Figured it out. The issue has to do with the DUI being hosted on github.io. If you throw the DUI up on a domain that you control or even hosted on the fivem server itself and change this line to wherever you host it, it does not play ads anymore https://github.com/kibook/pmms/blob/5f556010d63affcd4750e05d1171f218cc019e51/config.lua#L726

FerhatTurbo commented 1 month ago

Figured it out. The issue has to do with the DUI being hosted on github.io. If you throw the DUI up on a domain that you control or even hosted on the fivem server itself and change this line to wherever you host it, it does not play ads anymore

https://github.com/kibook/pmms/blob/5f556010d63affcd4750e05d1171f218cc019e51/config.lua#L726

Can you give some more details?

Thnight86041 commented 1 month ago

Figured it out. The issue has to do with the DUI being hosted on github.io. If you throw the DUI up on a domain that you control or even hosted on the fivem server itself and change this line to wherever you host it, it does not play ads anymore

https://github.com/kibook/pmms/blob/5f556010d63affcd4750e05d1171f218cc019e51/config.lua#L726

How can it be hosted on the server?

JordanZABOT commented 1 month ago

I will make a repoamd test later so it can be hosted on the FiveM server. Although I’m not sure if it will work yet. The cfx.re server endpoint URL may not work and may have ads. What I was thinking about doing is just hosting the DUI and serving it with SetHttpHandler to serve the static files. In case you don’t know what the DUI is it’s this: https://github.com/kibook/pmms-dui all you need to do is get these files uploaded to a static file server and serve them - it must be HTTPS for YouTube to work.

FerhatTurbo commented 1 month ago

image

advertising problem continues

Thnight86041 commented 1 month ago

I'll try to host it with httpmanager

Thnight86041 commented 1 month ago

We can host with httpmanager you just drag and drop the downloaded copy of pmms-dui

Then modify the pmms config.lua file as follows : Config.dui.urls.https = "http://[server IP]:[server port]/httpmanager/pmms-dui/"

For me it works

JordanZABOT commented 1 month ago

image

advertising problem continues

You can’t use anything with github.io. It has to be a different top level domain

JordanZABOT commented 1 month ago

I’m about to sit down and work on a repo that will hopefully work standby

Thnight86041 commented 1 month ago

I’m about to sit down and work on a repo that will hopefully work standby

Look at my answer I managed to remove the ads

JordanZABOT commented 1 month ago

I’m about to sit down and work on a repo that will hopefully work standby

Look at my answer I managed to remove the ads

I saw it, but I’m going to make something that will be an easy drag and drop solution for the people since this repo is not being maintained anymore

Thnight86041 commented 1 month ago

Fine

JordanZABOT commented 1 month ago

Done

https://github.com/JordanZABOT/pmms-dui

Thnight86041 commented 1 month ago

Very nice script and correction but I have a failled with 30000ms and nothing launches.

JordanZABOT commented 1 month ago

Very nice script and correction but I have a failled with 30000ms and nothing launches.

Add me on discord jordanzabot

hormoskunk commented 2 weeks ago

I’m about to sit down and work on a repo that will hopefully work standby

Look at my answer I managed to remove the ads

with your idea I have the same problem with 30000ms and nothing launches...

and with this idea

Done

https://github.com/JordanZABOT/pmms-dui

sometimes it works and sometimes I have got the same fail with 30000ms... I don't even restart server, 2 days was working and then 3 days dont, then 1 afternoon was working right now once again dont, I'm lost what to do...

PassiveRolePlayer commented 2 weeks ago

is this all up and working good as now ? i have made a few changes to pmms that i'd hate to re do from updating to the latest pmms, my default config line is Config.dui.url = "https://kibook.github.io/pmms"

ReallyPluto commented 1 week ago

so is there any real fix for this?

bobatari commented 1 week ago

If you guys are still having issues, update your dui.url.https to this

https://optimalrp.com/pmms-dui

Just did what someone said earlier.