search

kibu-australia / pushy

Clojurescript library for quick and easy HTML5 pushState
Eclipse Public License 1.0
223 stars 28 forks source link

svg use tags also have href attributes #27

Open leroix opened 7 years ago

leroix commented 7 years ago

It's common to use svg's in anchor tags with xlink'ing. Occassionally, a click will target the use tag, and since it has an href attribute, recur-href will stop there instead of iterating up to the anchor tag.

Shouldn't the recur-href function check whether the element is an anchor tag?

related: https://github.com/kibu-australia/pushy/issues/15

livtanong commented 7 years ago

Running into this issue as well. My urls are unexpectedly being set to [object SVGAnimatedString].

livtanong commented 7 years ago

@wavejumper I saw that you replied to this thread (was notified via email), but it seems to be missing. You mentioned updating the logic, but I haven't seen any updates of this nature on master.

wavejumper commented 7 years ago

@levitanong Yeah, sorry about that! I only understood the nature of this problem after I made my comment.

I'll merge in @leroix PR this weekend when I get the chance. Apologies for the delay

livtanong commented 7 years ago

Oh okay! Awesome. Thanks guys!

bleakley commented 5 years ago

area tags also have href attributes.