search

kickingvegas / casual-calc

Casual Calc - An opinionated Transient user interface for Emacs Calc.
GNU General Public License v3.0
136 stars 6 forks source link

Support L10n/i18n #140

Open ISouthRain opened 5 months ago

ISouthRain commented 5 months ago

Example:

图片

Easier to use for speakers of different native languages it will not affect the branch main code

ISouthRain commented 5 months ago

Pull requests 141

kickingvegas commented 5 months ago

@ISouthRain Thanks much for making this enhancement request! That said, I would prefer to rely on a generalized approach to L10n/i18n and so have made an enhancement request to Transient. https://github.com/magit/transient/issues/285

While I appreciate that you have taken the time to make a pull request, I must unfortunately decline it as it takes an approach of replicating the UI which I think is problematic when multiple languages are supported:

A better approach is to have a translation catalog from which a localization setting can be used to obtain the desired value (in this case a string).

Once an L10n/i18n solution is in place, I would be happy to get your input through that for Casual.

ISouthRain commented 5 months ago

@ISouthRain Thanks much for making this enhancement request! That said, I would prefer to rely on a generalized approach to L10n/i18n and so have made an enhancement request to Transient. magit/transient#285

While I appreciate that you have taken the time to make a pull request, I must unfortunately decline it as it takes an approach of replicating the UI which I think is problematic when multiple languages are supported:

* UI changes require changes to multiple copies of the UI per language.

* Testing requires multiple copies per language.

A better approach is to have a translation catalog from which a localization setting can be used to obtain the desired value (in this case a string).

Once an L10n/i18n solution is in place, I would be happy to get your input through that for Casual.

Oh, thank you very much. I've noticed it, and I wonder what your next thoughts are on the i18n language. If possible, please reply here Finally, thank you for your work. Great !!