search

kickingvegas / casual-dired

Casual Dired - An opinionated Transient user interface for Emacs file manager Dired.
GNU General Public License v3.0
124 stars 2 forks source link

Nitpick: "UTF-8" #36

Closed meedstrom closed 3 months ago

meedstrom commented 3 months ago

This is no big deal, but it struck me as a little odd-sounding in the readme. As I understand it, they're Unicode symbols, not UTF-8 symbols.

UTF-8 is a way to encode Unicode, and Unicode is the giant table of codepoints that defines how each one should approximately look (which is then implemented slightly differently by various fonts). The Transient buffer could technically be coded as UTF-16 or UTF-32 (no reason though) and still show the same symbols, given the same font. I think.

kickingvegas commented 3 months ago

Doh. Thanks for the clarification! Will amend.

kickingvegas commented 3 months ago

Just pushed out fix in v1.1.0. This should be on MELPA shortly.

meedstrom commented 3 months ago

You've got quite a professional process! I've never submitted a PR to myself. Do you feel benefits from doing it that way? Not snarking, just curious if it's something I should do too.

kickingvegas commented 3 months ago

@meedstrom As with all things involving computers, “it depends.” I’ve found in writing software that being disciplined about making changes is a net positive. It is largely a gift to your future self or to others who will work with it because invariably you’ll leave that codebase for some period of time, losing track of what you did. Having a good record of changes can help you recover that knowledge. This is especially the case for software you intend to make public. So I make PRs even though I’m the sole maintainer right now. That said, a lot of the mechanics of making a PR I have automated using a Makefile and gh which will pre-populate/generate notes from your commit messages. If your commit messages are clean then it is a significant time saver.