search

kickscondor / fraidycat

Follow blogs, wikis, YouTube channels, as well as accounts on Twitter, Instagram, etc. from a single page.
Other
1.76k stars 56 forks source link

Fraidycat breaks Gitlab somehow #178

Open maxim1317 opened 4 years ago

maxim1317 commented 4 years ago

Before you start.

Desktop (please complete the following information):

Fraidycat 1.1.7

Describe the bug It's a weird bug, but maybe you'll find something So, my company has an on-premise Gitlab installation and it worked fine. But today I've found that "Go Back" button doesn't work as expected on gitlab site. Instead of going back (yeah) to previous page, it shows login page. And it doesn't work either - shows error 422 on login attempt.

I've tried:

So, I turned off all of my extensions and turned them on one by one And yeah, it was fraidycat

It's not a critical bug for me, but maybe you'll find it helpful

medicinecal commented 4 years ago

Ok wow - yeah our Chrome extension updated last night, so some new change must have broken this. Thank you for reporting it!

I am not familiar with Gitlab at all? Is there a way of finding this page on a public Gitlab instance somewhere? Also - where would I find the "Go Back" button in its interface? Let's start there.

maxim1317 commented 4 years ago

Well, I have no idea why, but I can't reproduce this issue on gitlab.com. I can try record some logs from chrome.

About "Go Back" button: I am talking about Chrome's button image Sorry, I forgot how it is called properly

medicinecal commented 4 years ago

Is your URL http or https? Is it on a specific port? Can you give me the rough format of the hostname - like are you just using "hostname" or "hostname.lan" or something more detailed than that?

Thank you again for your help on this!

maxim1317 commented 4 years ago

Yeah, sure https://gitlab.companyname.com

I don't know if it will help, but I just noticed, that the [possible] bug appears to only show up when I'm navigating to the root page (https://gitlab.companyname.com) and only when I'm doing it with "Back" and "Forward" buttons.

And now it gets a little bit more interesting It actually happens on all internal services.

Maybe it is some misconfiguration in our network, but it somehow only shows up with Fraidycat on

kolen commented 4 years ago

Happens for me too (1.1.7) and not only on Gitlab, but on many websites that has login functionality, so it's not gitlab-specific. But it does not occur on all websites, for example it does not occur here on github. When going back and forward in browser history, pages are probably reloaded without login cookie. ~For some reason, after disabling and enabling again Chrome extension, it stopped to occur (so I can't get more information for now).~ Update: It's strange that when Chrome DevTools is open, it does not occur.

peterc commented 3 years ago

When going back and forward in browser history, pages are probably reloaded without login cookie.

I experienced this issue all over the place last year (esp on our internal systems, but also on Hacker News where if I ever pressed back, I was shown logged out pages) and thought Chrome had broken. It took a long time to determine Fraidycat was the cause and it's been disabled since.

kickscondor commented 3 years ago

Okay I've just checked in aabefcd to address this. It still needs some finessing - hope to test it and have it out over the weekend.

Thank you all for your persistence in bring this to my attention. I'm serious - I want this to improve.

kickscondor commented 3 years ago

A fix for this is finally out for Firefox. Chrome store to update in the next few days. Thank you!