search

kickscondor / fraidycat

Follow blogs, wikis, YouTube channels, as well as accounts on Twitter, Instagram, etc. from a single page.
Other
1.76k stars 56 forks source link

Feature/link target #205

Closed rafapaezbas closed 3 years ago

rafapaezbas commented 3 years ago

Hello,

I am new to Open Source contributions and this is the first PR I do to a Open Source project, honestly its only kind of an experiment because I would like to learn how to contribute.

I have seen issue #203, and I thought I could give it a try. I am not familiar with Hyperapp architecture, but I have tried following the way settings work in the app.

This settings option is only visible for the web extension because for the App, the links are always open in a different window.

Thank you very much for your time and your work, that I think is really amazing!

Best regards, Rafa

kickscondor commented 3 years ago

This is so cool! Thank you, Rafa. I'm sorry I haven't been around enough to inspect this. But it looks good and I hope to get this applied in the next week.

Thank youuuu!

magasine commented 2 years ago

Being able to open links in new page is really very useful. You could add a script on page load, something like:

javascript: var linksArr = document.getElementsByTagName("a");
for (i = 0; i < linksArr.length; i++) {
    linksArr[i].setAttribute("target", "_blank");
}