kickscondor / fraidycat

Follow blogs, wikis, YouTube channels, as well as accounts on Twitter, Instagram, etc. from a single page.
Other
1.76k stars 56 forks source link

Duplicate subscriptions occasionally appear #73

Open emceeaich opened 4 years ago

emceeaich commented 4 years ago

Desktop (please complete the following information):

Describe the bug

kickscondor commented 4 years ago

The channel URL is correct - Fraidycat translates user URLs into channel URLs. I may be able to use the original URL - but it's a low priority at the moment.

However, the duplicates issue is something I see crop up from time to time. This has to do with my templates - it should allow only one entry for every ID, but I see this sometime. If I can reproduce it, I will fix it - but your steps didn't get me there quite yet.

But yeah. Thank you for this useful information!

kickscondor commented 4 years ago

Ok was just able to make this happen with a Twitch follow.

Basically, when I visit its proper tab, two appear. Then I move to other tabs and the copy appears on those tabs (no matter the label or 'importance'). The copy appears to be out of date. So I am guessing this is a race condition. The copy is meant to be replaced, but instead becomes an orphan of some kind - without a key

I've got a second follow doing it now - a Reddit link. The copies also aren't sorted properly. (The subreddit shows a time of '3h' but is beneath follows that show '1d'.)

kickscondor commented 4 years ago

Removing the 'key' to prevent duplicates using a hash has solved this for me. Firefox should update soon - if we continue to see it, I have some ideas for tracking it further.

kickscondor commented 4 years ago

This is still a problem. I get duplicates that go away when I refresh. Could still be a bug in Hyperapp - unlikely though. I think there are duplicate entries in follows.all. Perhaps the JSON patching is failing. The IDs appear to be fine though.

poacher2k commented 4 years ago

Hi! First off, thank you so much for creating this awesome extension. It has really made following some great content creators a lot easier :)

I'm still experiencing this issue, but only with a couple of blogs - my own, and that of Marios Fakiolas image

medicinecal commented 4 years ago

Hi, thank you for reporting this.

Roughly when did these duplicates appear? Just in the last few days?

poacher2k commented 4 years ago

@medicinecal : They have been appearing from time to time over the last couple of months. When reporting this issue yesterday, I was on my work laptop and deleted -> re-added both those blogs. Right after re-adding there are only 1 of each. Now, on my home computer, one of the blogs have again become duplicate.

image

richardtatum commented 4 years ago

I am also still getting these duplicates fairly frequently, although with Youtube channels.

For me, it appears to happen mostly when I open Fraidycat on another device. If I delete the duplicates from my main PC, close the tab and then open the laptop, I find duplicates on the laptop.

Oddly, its only on the one section and it isn't every entry, although it does appear to affect the entries one by one. The next time I check there may be the original duplicate and one additional one.

Additional information if it is at all helpful:

If I can provide anything else to help, let me know.

medicinecal commented 4 years ago

@richardtatum Brilliant! Thank you for these details. I have been able to repro this, so hopefully I can get a fix together soon.