kickstartDS / ds-agency

https://storybook.basic.design-system.agency/
Other
3 stars 0 forks source link

Count controls in docs views #19

Closed julrich closed 8 months ago

julrich commented 11 months ago

Count controls added by our kickstartDS getArgsShared seem to be still missing something to be displayed correctly in the Docs page: image

Works as expected on the canvas: image

See: https://main--64f08cbba622af835d382b4f.chromatic.com/?path=/story/components-logos--centered-with-button&args=logos__count:5

julrich commented 8 months ago

As this works in Controls themselves, this can be closed I think? Before we had those controls as part of the Docs-page, too (compare to: https://www.kickstartds.com/storybook/?path=/docs/base-button--solid in the Docs tab).

But I think that's a bit redundant anyway... should just use Canvas views with "real" Controls when wanting to change the component.