search

kickstartDS / ds-agency

https://storybook.basic.design-system.agency/
Other
3 stars 0 forks source link

Fix remaining `strict mode: missing type "object" for keyword...` instances in schemas #21

Closed julrich closed 8 months ago

julrich commented 11 months ago

There are still / again some of those warnings currently. Could also be needed to add fixes in our kickstartDS modules.

julrich commented 8 months ago

Those warnings are gone now, but we're still left with one upstream problem with Select Field:

strict mode: type "string" not allowed by context "object" at "http://schema.kickstartds.com/form/select-field.schema.json#/properties/icon/allOf/0" (strictTypes)
strict mode: type "string" not allowed by context "object" at "http://schema.kickstartds.com/form/select-field.schema.json#/properties/icon/allOf/1" (strictTypes)
julrich commented 8 months ago

Above errors should be addressed in: https://github.com/kickstartDS/kickstartDS/pull/1573

julrich commented 8 months ago

This is fixed with: https://github.com/kickstartDS/ds-agency/commit/0638c33a2f58c2dc77361813b90a087dea17dd28