search

kickstartDS / ds-agency

https://storybook.basic.design-system.agency/
Other
2 stars 0 forks source link

List of Components featuring Button Group Provider #42

Open fleven-kds opened 7 months ago

fleven-kds commented 7 months ago

List of Components featuring a ButtonGroup through the use of a ButtonContextProvider:

The current approach of integrating a ButtonGroup into components via ButtonContextProvider is not optimal. It would be more efficient and maintainable to find an alternative method for this integration. One potential solution could be to natively integrate them into the base kickstartDS components (Visual & Storytelling).

julrich commented 7 months ago

Somehow thought we'd have a ticket for this already... but was only able to come up with this one for our own, branded instance: https://github.com/kickstartDS/kickstartDS-storybook/issues/5

We should do this in kickstartDS/content, though. Directly changing how Storytelling and Visual work at the source. We already have won a ButtonGroup component in the meantime, which should be used in those components: https://github.com/kickstartDS/kickstartDS/blob/next/packages/components/base/source/button-group/ButtonGroupComponent.tsx