kickstartDS / ds-agency

https://storybook.basic.design-system.agency/
Other
2 stars 0 forks source link

Slider: Layout cant accommodate height differences #43

Closed fleven-kds closed 6 months ago

fleven-kds commented 7 months ago

The current layout implementation has a predefined height when it's rendered. This can lead to issues where items that exceed this set height are truncated or cut off. To address this, there are two potential solutions:

  1. Uniform Item Height: Adjust all items to have the same height. This would involve stretching smaller items to match the height of the largest item, ensuring that no content is cut off.

  2. Dynamic Slider Height: Modify the slider to automatically adjust its height based on the size of the largest item. This would ensure that the slider's height is always sufficient to display the largest item in full, without the need to alter the height of individual items.

Screenshot 2023-12-14 at 08 17 39 Screenshot 2023-12-14 at 08 17 46
fleven-kds commented 7 months ago

It seems that the slider does attempt to adjust its height dynamically as new items slide into view. However, the slider often does not allocate sufficient height for the incoming items, resulting in them being cut off.