search

kickstartDS / storybook-addon-jsonschema

Displays associated JSON Schema documentation using a rich schema explorer interface, and adds a validating JSON Code Editor with semantic auto-complete to interact with your components, and copy configurations with ease.
https://www.kickstartDS.com/docs/integration/storybook/schema
MIT License
12 stars 1 forks source link

Upgrade react peer depenendency #20

Closed stephenliang closed 9 months ago

stephenliang commented 1 year ago

The package currently only declares a peer dependency React 16 and 17 so when installing for React 18 repos, I get this following error. Can a peer for React 18 be added? Thank you!

npm ERR! While resolving: XXXXXXXX
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   dev react@"^18.2.0" from XXXXXXXX
npm ERR!   packages/XXXXXXXX
npm ERR!     XXXXXXXX
npm ERR!     node_modules/XXXXXXXX
npm ERR!       workspace packages/XXXXXXXX from the root project
npm ERR!       1 more (XXXXXXXX)
npm ERR!   peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @storybook/addons@6.5.15
npm ERR!   node_modules/@storybook/addons
npm ERR!     peer @storybook/addons@"^6.3.6" from @kickstartds/storybook-addon-jsonschema@1.0.6
npm ERR!     node_modules/@kickstartds/storybook-addon-jsonschema
npm ERR!       dev @kickstartds/storybook-addon-jsonschema@"^1.0.6" from XXXXXXXX@0.1.0
npm ERR!       XXXXXXXX
npm ERR!         XXXXXXXX@0.1.0
npm ERR!         XXXXXXXX
npm ERR!   4 more (react-dom, @storybook/api, @storybook/components, @storybook/theming)
npm ERR!
julrich commented 1 year ago

Hey, we'll get to this soon. We're currently upgrading everything to Storybook 7, which entails also cleaning up house here. This also includes upping the peer dependency on React to 18! Will comment again when the release is ready!

You can also track the progress here: