search

kickstarter / cfn-flow

A practical workflow for AWS CloudFormation
168 stars 15 forks source link

YAML to JSON conversion unnecessary and broken #25

Open doismellburning opened 7 years ago

doismellburning commented 7 years ago

CloudFormation now supports YAML templates natively, rendering cfn-flow's "converts from YAML to JSON" obsolete

In addition, CloudFormation Intrinsic Functions have a YAML "short form" (e.g. !GetAtt foo.bar) that cfn-flow naïvely transforms to JSON, turning a valid CF YAML template into invalid CF JSON

(If you confine yourself to the "long form" of the functions, it's fine)

ktheory commented 7 years ago

@doismellburning Yup! Totally correct. I'd welcome a PR to removes the conversion to JSON.