kidd / org-gcal.el

Org sync with Google Calendar. (active maintained project as of 2019-11-06)
432 stars 47 forks source link

Fix Readme (Issue #213) #226

Closed malleyeno closed 6 months ago

malleyeno commented 1 year ago

This PR fixes issue #213 by updating the readme file with the changes made to get around the new Oauth2-auto method being used for authentication. It also has some items from the discussion has in that issue, including:

Issues I noticed while reviewing the change log that git generated that there are over 800 changes in this PR. I believe this may be due to how it got separated into line breaks within paragraphs when I tried to fork from master in Magit, since I know I did not edit the entire readme file (though I don't know if it was like that originally).

If this is an issue preventing merge, I would appreciate support in figuring out how to get just the relevant edits made.

aspiers commented 1 year ago

@malleyeno If I view the diff with the option to ignore whitespace enabled then it looks correct, so you probably just need to remove the changes to the EOL characters or whatever is causing these whitespace differences.

telotortium commented 1 year ago

@malleyeno Please fix the diff before I review the changes. Also, please rebase on latest master.

malleyeno commented 1 year ago

@telotortium Should be good now! Turns out that it was a CRLF issue. I just switched over to LF.

There were additions to the readme about asymmetrical keys that were reported as conflicts. I kept both in there just in case one ends up working for the user over the other.

licht1stein commented 9 months ago

Updating readme is a very good idea :)

marcelruland commented 6 months ago

I just set up org-gcal using this readme after I got properly confused by the one on main. This PR should be reviewed/merged.

telotortium commented 6 months ago

@marcelruland merged - sorry for leaving this unmerged.