search

kiddac / XStreamity

Enigma2 plugin is for playing official Xtream Codes IPTV playlists.
41 stars 27 forks source link

twisted downloadPage #23

Open jbleyel opened 2 years ago

jbleyel commented 2 years ago

You should remove downloadPage.

Check this:

https://github.com/twisted/twisted/releases/tag/twisted-22.1.0rc1 ->

Deprecations and Removals

twisted.web.client.getPage, twisted.web.client.downladPage, and the associated implementation classes (HTTPPageGetter, HTTPPageDownloader, HTTPClientFactory, HTTPDownloader) have been removed because they do not segregate cookies by domain. They were deprecated in Twisted 16.7.0 in favor of twisted.web.client.Agent. https://github.com/advisories/GHSA-92x2-jw7w-xvvx. (#10295)

kiddac commented 2 years ago

twisted.web.client is documented horrendously. I am not a developer but just a hobbyist. I wouldn't even know how to make this change and if I did it would probably break lots of older images that have very old versions of twisted.

kiddac commented 2 years ago

Had a go at this yesterday, I can download some stuff with twisted agent, but then we still have the age old problem of getting https downloads to work with twisted web. The old way of using downloadpage used a bit of a hack to get arround the SSL certificates issue. At the moment I don't know any solution to get around the https issue with twisted agent.

kiddac commented 2 years ago

There are a few scenarios to consider. We can probably use concurrent futures to download stuff none blocking (but not all images have concurrent futures) We can't using threading properly because dreamos prevents most threading We use twisted web as its none blocking - but we have issues with https:// downloads.

My plugins work on all images not just one image or latest versions of images