search

kidonng / daisyui

A UnoCSS-compatible redistribution of daisyUI
https://npm.im/@kidonng/daisyui
MIT License
21 stars 2 forks source link

Sync to 2.42.1 #2

Closed philippedasilva-orizone closed 1 year ago

philippedasilva-orizone commented 1 year ago

Hi,

This is a simple sync to 2.42.1 Hope this PR finds you, @kidonng pretty soon as I'm right now forced to import my fork as a submodule in my monorepo to be able to get the fix added to this version of daisyui ;)

Thanks for this great work btw.

kidonng commented 1 year ago

Sorry for the long wait! I'm doing the sync now.

I appreciate your efforts, but only the submodule changes are necessary, maybe next time I'm not catching up with updates, I will merge it 😃

philippedasilva-orizone commented 1 year ago

It's your call @kidonng but I would recommend using the dist of the daisyui package instead of the source code to avoid compatibility issues with design choices made. For instance, the chat component doesn't work if you're not using the dist files.

kidonng commented 1 year ago

I would recommend using the dist of the daisyui package instead of the source code to avoid compatibility issues with design choices made. For instance, the chat component doesn't work if you're not using the dist files.

Fixed in #3, please try the latest version (v2.50.1-0) 😊