search

kidpollo / tanker

IndexTank Integration with your fav ORM
MIT License
97 stars 30 forks source link

Disabling pagination returns max: 10 results #48

Closed joemsak closed 13 years ago

joemsak commented 13 years ago

Given the same search term:

When I use :paginate => false, I get 10 results

when I put the normal pagination options back in (:page => params[:page], :per_page => x) I get 145 results

kidpollo commented 13 years ago

can you try using the 'edge' version. I thought I had a fix for this already.

kidpollo commented 13 years ago

I just merged some changes from a pull request done by @adrnai which do some changes to the instatiation logic can you please test your code by using the code from master

gem 'tanker', :git => 'git://github.com/kidpollo/tanker.git'

joemsak commented 13 years ago

Trying now, thank you

On Thu, Sep 22, 2011 at 3:10 AM, kidpollo < reply@reply.github.com>wrote:

I just merged some changes from a pull request done by @adrnai which do some changes to the instatiation logic can you please test your code by using the code from master

gem 'tanker', :git => 'git://github.com/kidpollo/tanker.git'

Reply to this email directly or view it on GitHub: https://github.com/kidpollo/tanker/issues/48#issuecomment-2165138

joemsak commented 13 years ago

Hmmm, I still get 10 results for the same search with :paginate => false, that produces 144 results with :per_page => 5000, :page => params[:page]

On Thu, Sep 22, 2011 at 9:09 AM, Joe Sak joe@joesak.com wrote:

Trying now, thank you

On Thu, Sep 22, 2011 at 3:10 AM, kidpollo < reply@reply.github.com>wrote:

I just merged some changes from a pull request done by @adrnai which do some changes to the instatiation logic can you please test your code by using the code from master

gem 'tanker', :git => 'git://github.com/kidpollo/tanker.git'

Reply to this email directly or view it on GitHub: https://github.com/kidpollo/tanker/issues/48#issuecomment-2165138

oleksify commented 13 years ago

Have same issue. Any help?

kidpollo commented 13 years ago

I know the problem, the thing is that Index Tank seems to enforce a default of 10

"len": how many results to return (default: 10)

I think I will remove supporting the 'false' option because assuming a number might be counter intuitive.

Opinions?

kidpollo commented 13 years ago

http://indextank.com/documentation/api

Always check the index api for reference :P

kidpollo commented 13 years ago

Upgraded the gem to not support the :paginate false