search

kidrigger / godot-videodecoder

GDNative Video Decoder libraries for Godot Game Engine, using FFmpeg library for codecs. A Google Summer of Code Project, 2018
MIT License
84 stars 22 forks source link

Upgrade to GDExtension for 4.0 #41

Closed fire closed 9 months ago

fire commented 3 years ago

GDNative was removed in Godot Engine 4.0.

fire commented 3 years ago
  1. [ ] verify all things work
  2. [ ] verify that audio sync issue is fixed
  3. [ ] verify that the releases work as expected
  4. [ ] investigate transfer to Godot Engine organization as an official plugin
jamie-pate commented 3 years ago

4 (transfer to godot org) would be really nice, I currently have very little time to help out with this :)

kidrigger commented 2 years ago

I would prefer this being transferred to the org as well. It's an important part - and I lack the time to maintain this. Need to check if this can be easily moved to a GDExtension else it's better to be re-written as there are issues due to mistaken core assumptions about the A/V playback.

fire commented 2 years ago

Please document:

Mistaken core assumptions about the A/V playback.

kidrigger commented 2 years ago

Please document:

Mistaken core assumptions about the A/V playback.

Currently, the video plays as at the timestamp or earliest possible, with audio synchronizing to it. This was to be fixed (but I'm unsure if it has been) The correct way is for the video to synchronise to audio.

However this bug is on the godot side of the code. The decoder plugin itself shouldn't be affected and probably can just be copied over.

aXu-AP commented 1 year ago

Now that Godot 4 is nearing beta, is there any plans to continue working on this?

kidrigger commented 1 year ago

The GDExtension repo is https://github.com/kidrigger/godot-video-reference

aXu-AP commented 1 year ago

Thanks! Is this going to support ffmpeg as well?

kidrigger commented 1 year ago

That's the goal. Currently stuck due to lack of time on my part as I'm a full time student.

Adding WebM support first since it was removed from Godot. Then I'll make the ffmpeg one.

On Fri, Sep 9, 2022, 16:06 aXu-AP @.***> wrote:

Thanks! Is this going to support ffmpeg as well?

— Reply to this email directly, view it on GitHub https://github.com/kidrigger/godot-videodecoder/issues/41#issuecomment-1242020196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDSN5UYP24655RKA5FZ7UTV5M77HANCNFSM5DEK2IIA . You are receiving this because you commented.Message ID: @.***>

aXu-AP commented 1 year ago

Nice to hear and I wish you well on studys. I'd gladly help but C++ is no go for me :/

Anemony22 commented 1 year ago

Is there any news on this? I'd love to use the seek functionality in a current project. Our current workaround is just linking to a YouTube video, which is less than ideal.

yunylz commented 9 months ago

bump?

kidrigger commented 9 months ago

Those project should fit the needs. This repo is not actively maintained.

https://github.com/EIRTeam/EIRTeam.FFmpeg