kids-first / kf-alignment-workflow

:microscope: Alignment workflow for Kids-First DRC
Apache License 2.0
10 stars 6 forks source link

Update picard docker #118

Closed sickler-alex closed 3 years ago

sickler-alex commented 3 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Update all picard tools to use the pgc-images.sbgenomics.com/d3b-bixu/picard:2.18.9R docker.

Fixes # https://app.zenhub.com/workspaces/d3b-bfx-5cdd720eed0dce4209e0b8a5/issues/d3b-center/bixu-tracker/1102

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

sickler-alex commented 3 years ago

To compare the runs, I pulled the qc metrics for these runs and compared them. Attached is the excel file with the metrics and the comparison. metrics_comp.xlsx

sickler-alex commented 3 years ago

@migbro did I miss a place for the version number? The last commit updates the link to the new tag that will get created once this is approved.

migbro commented 3 years ago

@migbro did I miss a place for the version number? The last commit updates the link to the new tag that will get created once this is approved.

Ah, so I was referring to the github release version, sorry. So in the scripts workflows/kfdrc_alignment_wf.cwl and workflows/kfdrc-gatk-haplotypecaller-wf.cwl, these lines:

- id: 'https://github.com/kids-first/kf-alignment-workflow/releases/tag/v2.7.0'
  label: github-release
- id: 'https://github.com/kids-first/kf-alignment-workflow/releases/tag/v2.6.0'
  label: github-release

Just increment increment each by 0.0.1 please. Thanks!