kids-first / kf-alignment-workflow

:microscope: Alignment workflow for Kids-First DRC
Apache License 2.0
10 stars 6 forks source link

🚇 Public App File Index Handling #95

Closed dmiller15 closed 4 years ago

dmiller15 commented 4 years ago

Description

This PR addresses the changes necessary to make the workflow public app ready. Specifically these changes address the inability of having suggested secondaryFiles when running a public app.

The changes are made in the following ways:

Changes to the workflow structure

Resolves https://github.com/d3b-center/bixu-tracker/issues/661

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

dmiller15 commented 4 years ago

Most recent test for adding flexibility to untaring and a fix to bwa indexing: https://cavatica.sbgenomics.com/u/kfdrc-harmonization/kf-reference-pipeline/tasks/0d96e7e4-d92a-44c8-9c5b-efe7e9c68602/stats/

dmiller15 commented 4 years ago

Alright hopefully the last change to the fasta preprocessing. Keeping the tar unpacking but no longer supporting bwa, picard, or samtools indexing. Users will need to make their own. https://cavatica.sbgenomics.com/u/kfdrc-harmonization/kf-reference-pipeline/tasks/54a2b4b2-b928-4f13-96bc-31ffc3530a7f/stats/

migbro commented 4 years ago

If you look at the log in the test run, the command just seems to untar the whole thing wach time: tar xf /sbgenomics/Projects/0154a615-2b20-4c32-9c76-141b5eebdde1/Homo_sapiens_assembly38.tgz from https://cavatica.sbgenomics.com/u/kfdrc-harmonization/kf-reference-pipeline/tasks/54a2b4b2-b928-4f13-96bc-31ffc3530a7f/stats/ I thought it was supposed to grab a specific file?

dmiller15 commented 4 years ago

I changed the way the tar process works. The single file untar process was only working when I used exact file names so I just decided to untar everything and sort it out with the glob.