kids-first / kf-api-dataservice

:file_cabinet: Primary API for interacting with the Kids First data
http://kf-api-dataservice.kidsfirstdrc.org
Apache License 2.0
5 stars 2 forks source link

✨ Add new SE, GF columns for Bix #650

Closed znatty22 closed 5 months ago

znatty22 commented 5 months ago

Todo

HuangXiaoyan0106 commented 5 months ago

@znatty22 We have updated the kf_pipeline_outputs.csv file.

HuangXiaoyan0106 commented 5 months ago

@znatty22 It seems you didn't update the data_type enum, like Metric -> Metrics, Read -> Reads, as I listed. or you will create a new PR for this?

znatty22 commented 5 months ago

@znatty22 It seems you didn't update the data_type enum, like Metric -> Metrics, Read -> Reads, as I listed. or you will create a new PR for this?

@HuangXiaoyan0106 This requires a bigger effort because we have to ensure that none of the existing data uses old values before we get rid of them or we have to do a data migration. Since this is a bigger effort and different from adding new fields, I think it should be in a separate PR

yuankunzhu commented 4 months ago

@znatty22 It seems you didn't update the data_type enum, like Metric -> Metrics, Read -> Reads, as I listed. or you will create a new PR for this?

@HuangXiaoyan0106 This requires a bigger effort because we have to ensure that none of the existing data uses old values before we get rid of them or we have to do a data migration. Since this is a bigger effort and different from adding new fields, I think it should be in a separate PR

@znatty22 @HuangXiaoyan0106 we don't have to get rid of the old enum, I think for now, we just wanna make sure we have all the new enum added for the "data_type"