kids-first / kf-model-fhir

🔥 FHIR Data Model for Kids First
https://kids-first.github.io/kf-model-fhir/ig/
Apache License 2.0
1 stars 1 forks source link

✨ Add sequencing experiment conformance resources #198

Open nicholasvk opened 4 years ago

nicholasvk commented 4 years ago

This PR adds sequencing experiment example resources. It also closes #190.

nicholasvk commented 4 years ago

The Observation here looks like it's describing the GF, not the SE at all. Giving it ID prefix "s" and text "sequencing_experiment" seems inapt.

It is describing what was observed about a GF as a result of the sequencing experiment. Our thinking was that since this information will only be derived as part of the output of a sequencing experiment, that it made sense to code it the same way to indicate a relationship between this observation and task. I see your point though, and am open to making the change if @liberaliscomputing agrees.