kids-first / kf-portal-ui

:bar_chart: The Kids First Data Resource Portal and Social Network User Interface
Apache License 2.0
25 stars 14 forks source link

Query Summary: Survival Plot Card Display #1108

Closed rosibaj closed 5 years ago

rosibaj commented 5 years ago

Design screen shot 2019-02-08 at 3 58 42 pm Zeplin: https://zpl.io/boKj4kM

Data Specs: https://kidsfirst.atlassian.net/wiki/spaces/KFDRC/pages/888012823/Cohort+Builder+Technical+Specs#CohortBuilderTechnicalSpecs-SummaryView

It should accept data in this format:

"donors": [
{
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 6,
"survivalEstimate": 1,
"submitter_id": "PT_FCS416QR",
"id": "2c30dc20-18a8-44f9-ab10-558c1e5634dc"
},
{
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 14,
"survivalEstimate": 1,
"submitter_id": "PT_ARN1D5B8",
"id": "26a12266-c6d8-42f9-bd4e-5093d827ac9a"
},
{
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 16,
"survivalEstimate": .95,
"submitter_id": "PT_TQPMJMDF",
"id": "01240896-3f3f-4bf9-9799-55c87bfacf36"
},
{
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 28,
"survivalEstimate": .82,
"submitter_id": "PT_5HYPY6F9",
"id": "6fa41234-9077-4d05-a295-6820f3bedf5b"
},
{
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 32,
"survivalEstimate": .7,
"submitter_id": "PT_BADD0N51",
"id": "c46971a1-cbac-425d-bac2-f4142c92522e"
},
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 44,
"survivalEstimate": .44,
"submitter_id": "PT_GJYKSGM5",
"id": "c46971a1-cbac-425d-bac2-f4142c92522e"
},
"project_id": "Congenital Diaphragmatic Hernia",
"censored": true,
"time": 62,
"survivalEstimate": .32,
"submitter_id": "PT_1KYPR4ZK",
"id": "c46971a1-cbac-425d-bac2-f4142c92522e"
}]
nyanofthemoon commented 5 years ago

@rosibaj https://github.com/kids-first/kf-portal-ui/pull/1232

rosibaj commented 5 years ago

@nyanofthemoon Thanks for resolving all the build issues! Looks like its showing up great!

rosibaj commented 5 years ago

@nyanofthemoon I can see that its not in the mockup as it looks like we forgot to include the reset instructions after drag to zoom - wondering if it would possible for you to add that reset functionality in so we do not have to reload the page to reset the survival graph?