Make the facets panel width user-resizable

kids-first / kf-portal-ui

:bar_chart: The Kids First Data Resource Portal and Social Network User Interface

Apache License 2.0

25 stars 14 forks source link

Make the facets panel width user-resizable #814

Closed Fgerthoffert closed 5 years ago

Fgerthoffert commented 5 years ago

Add the ability to change the size, or collapse the left facet panel.

As examples:

HCMI has the abiltiy to expand (https://hcmi.netlify.com/)
GDC has the ability to collapse (https://portal.gdc.cancer.gov/exploration)

Mockup: Zeplin: https://zpl.io/bev8YdN Similar to HCMI, the crosshair icon will show up when the user hovers over the edges of the panels (both facet and action panels). The title area of the facet panel will change slightly to match the collapsible style of the action panel.

screen shot 2018-12-04 at 11 14 54 am

nyanofthemoon commented 5 years ago

https://github.com/kids-first/kf-portal-ui/pull/1045

rosibaj commented 5 years ago

QA -

facet can collapse, but still not able to adjust the size of the panel (larger or smaller)
Can we also change the pointer so that when it is on the << it is the correct "click hand" pointer to help the user know they can click it?

rosibaj commented 5 years ago

@nyanofthemoon Vincent wants to go ahead and deploy with JUST the collapse - this looks fine in preview - can you merge to deploy?

nyanofthemoon commented 5 years ago

@rosi I merged this into the vr branch (preview). Do I need to merge this somewhere else as well? I'll ask in standup this morning.

nyanofthemoon commented 5 years ago

@rosibaj @hlminh2000 PR to merge from vr to next https://github.com/kids-first/kf-portal-ui/pull/1063

Closed my pull request out of worry about the integrity of the code. Will wait for the next merge upwards from vr unto next branch and next branch unto master branch.

rosibaj commented 5 years ago

tested on prod - working as expected. Nice work @nyanofthemoon !