kids-first / kf-rnaseq-workflow

:microscope: RNA-Seq workflow for Kids-First DRC
Apache License 2.0
9 stars 8 forks source link

🤖 automate strand detection #48

Closed dmiller15 closed 1 year ago

dmiller15 commented 1 year ago

Description

Fixes # (issue)

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

dmiller15 commented 1 year ago

Do you think it's helpful/worth it to add as an output string the detected strandedness? So, to the wf, add an output detected_strandedness and just put the string value that is passed to wf_strand_param?

It would save a few seconds. Because you can just go to the output.json for the bam_strandedness step. I'm hesitant to add a new output right now as it would impact the flow for OPs (they'll be getting a new output). Perhaps when we refresh the workflow we could consider string outputs to use for debugging.