search

kids-first / kf-uikit

🎨 Design System for Kids First
https://kf-uikit.netlify.com
Apache License 2.0
1 stars 1 forks source link

✨ Add button with icon #103

Closed XuTheBunny closed 5 years ago

XuTheBunny commented 5 years ago

Motivation

Add button with icon option on the storybook, taking IconType as prop. Adding paddings around the icon automatically. image

Use Cases

API changes

No API changes are made on this component.

Implementation Notes

If icon is null, it would hide icon and its paddings. For the icon options, it should be chosen within the Icon component in the story book.

Rendering and Storybook location

src/
└── components
    ├──Button
    │   ├── __tests__/
    │   ├── Button.jsx
    │   ├── Button.story.jsx
    │   └── Button.css
    └── index.js

Functional Tests

Test for button renders correctly with each type, size, if disabled, with/without icon.

Closes #84

dankolbman commented 5 years ago

UIKit Storybook for Review

Built with commit 54b91d2768882ebb05345c563bf321dfb091405c

https://deploy-preview-103--kf-uikit.netlify.com

bdolly commented 5 years ago

@XuTheBunny could we follow the PR template for this so as to help document it for review in the future?